fix(navbar): align scrolled navbar width with content sections#339
fix(navbar): align scrolled navbar width with content sections#339Br1an67 wants to merge 1 commit intokeploy:mainfrom
Conversation
Changed the scrolled navbar max-width from md:max-w-5xl to md:max-w-7xl to match the Container component's max-width. This ensures the navbar aligns properly with content sections like technology and community blogs when scrolled, improving visual consistency and user experience. Signed-off-by: Br1an67 <932039080@qq.com>
|
Hey @Br1an67 👋 — thanks for putting this PR together, we appreciate the effort! We've gone ahead and requested a Copilot review on this. Here's some context from the reviewer:
Once you've had a chance to go through the comments, please address the feedback and resolve the threads — and we'll get this across the line. Feel free to ask if anything's unclear. Happy coding! 💙 |
There was a problem hiding this comment.
Pull request overview
Updates the scrolled/shrunk floating navbar’s maximum width so it visually aligns with the same content width constraint used by the site’s Container sections (fixing keploy/keploy#3429).
Changes:
- Adjusted the scrolled navbar
md:max-w-*frommax-w-5xltomax-w-7xlinFloatingNavbar.tsxto match theContainercomponent’smax-w-7xl.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Thank you for the effort on the navbar width alignment, Brian! Tackling UI alignment issues requires patience and a good eye for detail. We are closing this PR at this time because the review feedback we shared - providing before-and-after screenshots and resolving the conflict with the related navbar alignment PR - has been open for over three weeks with no updates from the branch. Please do not be discouraged. There are other open issues in the repository and we would love to see more contributions from you! If you would like to discuss what to work on next, feel free to reach out on Slack at https://keploy.slack.com/join/shared_invite/zt-357qqm9b5-PbZRVu3Yt2rJIa6ofrwWNg |
Fixes keploy/keploy#3429
Summary
Fixed the navbar alignment issue where the scrolled/shrunk navbar width did not match the content sections on the landing page. The navbar now uses the same max-width as the Container component to ensure visual consistency.
Changes
md:max-w-5xl(1024px) tomd:max-w-7xl(1280px) incomponents/navbar/FloatingNavbar.tsxTesting
max-w-7xlfor content widthDiff Stats